xbps-query: add message when no packages have been found#501
Open
OfekShochat wants to merge 1 commit intovoid-linux:masterfrom
Open
xbps-query: add message when no packages have been found#501OfekShochat wants to merge 1 commit intovoid-linux:masterfrom
OfekShochat wants to merge 1 commit intovoid-linux:masterfrom
Conversation
|
Just my opinion as another user: While I too would like to see a message, this PR one is incomplete because:
I would argue it should also be shown without -v. |
Author
|
sure. if I change those, will this be done? |
|
No idea, you'd have to get an actual review from a Void Linux maintainer, in particular @Duncaen seems to be the one merging on this repo. |
58234b7 to
f9a8b39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #494